Fix warnings from better precision of dead_code lint
#9906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
The lint now ignores derived `Clone` and `Debug` implementations, as of PR rust-lang/rust#85200, which landed a couple of days ago. I sprinkled `#[allow(dead_code)]` in a few places; the fields are not expected to be read since they are just part of a very specific test.
camelid
force-pushed
the
fix-warnings
branch
from
105a4d9
to
f6823a6
Compare
|
@bors: r+ |
|
📌 Commit f6823a6 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Sep 13, 2021
ehuss
pushed a commit
to ehuss/cargo
that referenced
this pull request
Sep 14, 2021
Fix warnings from better precision of `dead_code` lint The lint now ignores derived `Clone` and `Debug` implementations, as of PR rust-lang/rust#85200, which landed a couple of days ago. I sprinkled `#[allow(dead_code)]` in a few places; the fields are not expected to be read since they are just part of a very specific test.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 17, 2021
Update cargo 13 commits in e515c3277bf0681bfc79a9e763861bfe26bb05db..33ee5f82edb50af87b952c5b28de0f5fb41ebf18 2021-09-08 14:32:15 +0000 to 2021-09-17 13:51:54 +0000 - Update curl-sys (rust-lang/cargo#9917) - Bump Cargo's curl requirement to 7.79.0 (rust-lang/cargo#9914) - Revert "When a dependency does not have a version, git or path, fails directly" (rust-lang/cargo#9911) - Add some contributor docs for debugging testsuite tests. (rust-lang/cargo#9904) - Fix warnings when documenting with `--document-private-items` (rust-lang/cargo#9903) - Improve "wrong output" error. (rust-lang/cargo#9905) - Fix warnings from better precision of `dead_code` lint (rust-lang/cargo#9906) - Bump to 0.58.0, update changelog (rust-lang/cargo#9900) - Fix rustc --profile=dev unstable check. (rust-lang/cargo#9898) - config.md: fix typo (rust-lang/cargo#9896) - Enable some tests on windows. (rust-lang/cargo#9893) - Enable strip test on macos. (rust-lang/cargo#9889) - Fix `cargo fix --edition` on stable. (rust-lang/cargo#9890)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint now ignores derived
CloneandDebugimplementations, as ofPR rust-lang/rust#85200, which landed a couple of days ago.
I sprinkled
#[allow(dead_code)]in a few places; the fields are notexpected to be read since they are just part of a very specific test.